search

hyperledger / aries-vcx

aries-vcx is set of crates to work with DIDs, DID Documents, DIDComm, Verifiable Credentials and Hyperledger Aries.
https://didcomm.org
Apache License 2.0
125 stars 83 forks source link

refactor: ledger & anoncreds typing, part 2 #1118

Closed mirgee closed 9 months ago

mirgee commented 10 months ago

Continuation of #1116.

codecov-commenter commented 10 months ago

Codecov Report

Attention: 531 lines in your changes are missing coverage. Please review.

Comparison is base (27fc82c) 0.05% compared to head (0a54b22) 0.05%.

Files Patch % Lines
...e/src/anoncreds/credx_anoncreds/type_conversion.rs 0.00% 93 Missing :warning:
aries/aries_vcx_core/src/ledger/type_conversion.rs 0.00% 81 Missing :warning:
aries/aries_vcx_core/src/ledger/indy_vdr_ledger.rs 0.00% 32 Missing :warning:
...ies/misc/test_utils/src/mockdata/mock_anoncreds.rs 0.00% 25 Missing :warning:
...s_vcx/src/common/primitives/revocation_registry.rs 0.00% 21 Missing :warning:
...vcx/src/common/primitives/credential_definition.rs 0.00% 20 Missing :warning:
aries/aries_vcx/tests/test_revocations.rs 0.00% 20 Missing :warning:
...ries_vcx_core/src/anoncreds/credx_anoncreds/mod.rs 0.00% 20 Missing :warning:
...cx/src/common/proofs/verifier/verifier_internal.rs 0.00% 19 Missing :warning:
aries/aries_vcx/tests/test_pool.rs 0.00% 19 Missing :warning:
... and 30 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1118 +/- ## ======================================== - Coverage 0.05% 0.05% -0.01% ======================================== Files 494 495 +1 Lines 24866 25124 +258 Branches 4459 4535 +76 ======================================== Hits 13 13 - Misses 24853 25111 +258 ``` | [Flag](https://app.codecov.io/gh/hyperledger/aries-vcx/pull/1118/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hyperledger) | Coverage Δ | | |---|---|---| | [unittests-aries-vcx](https://app.codecov.io/gh/hyperledger/aries-vcx/pull/1118/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hyperledger) | `0.05% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hyperledger#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.