hyperledger / aries-vcx

aries-vcx is set of crates to work with DIDs, DID Documents, DIDComm, Verifiable Credentials and Hyperledger Aries.
https://didcomm.org
Apache License 2.0
125 stars 83 forks source link

refactor: remove libvcx_core and vcx_napi_rs crates #1145

Closed xprazak2 closed 8 months ago

xprazak2 commented 8 months ago

Removing libvcx_core and vcx_napi_rs together with their CI actions.

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.05%. Comparing base (c2c0dde) to head (9b1c041).

:exclamation: Current head 9b1c041 differs from pull request most recent head c7934d9. Consider uploading reports for the commit c7934d9 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1145 +/- ## ===================================== Coverage 0.05% 0.05% ===================================== Files 506 506 Lines 25477 25477 Branches 4638 4638 ===================================== Hits 13 13 Misses 25464 25464 ``` | [Flag](https://app.codecov.io/gh/hyperledger/aries-vcx/pull/1145/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hyperledger) | Coverage Δ | | |---|---|---| | [unittests-aries-vcx](https://app.codecov.io/gh/hyperledger/aries-vcx/pull/1145/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hyperledger) | `0.05% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hyperledger#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

xprazak2 commented 8 months ago

Do we want to remove the js wrappers for agents as well?

Patrik-Stas commented 8 months ago

@xprazak2 yes please