search

hyperledger / aries-vcx

aries-vcx is set of crates to work with DIDs, DID Documents, DIDComm, Verifiable Credentials and Hyperledger Aries.
https://didcomm.org
Apache License 2.0
125 stars 83 forks source link

refactor: move wallet to a separate crate #1157

Closed xprazak2 closed 7 months ago

xprazak2 commented 8 months ago

Extracts wallet code from aries_vcx_core and moves it to a separate crate.

codecov-commenter commented 8 months ago

Codecov Report

Attention: Patch coverage is 0% with 256 lines in your changes are missing coverage. Please review.

Project coverage is 0.05%. Comparing base (37707bc) to head (21934fd).

:exclamation: Current head 21934fd differs from pull request most recent head cbf0531. Consider uploading reports for the commit cbf0531 to get more accurate results

Files Patch % Lines
aries/aries_vcx_wallet/src/errors/error.rs 0.00% 89 Missing :warning:
aries/aries_vcx_core/src/errors/mapping_wallet.rs 0.00% 26 Missing :warning:
aries/misc/test_utils/src/mock_wallet.rs 0.00% 24 Missing :warning:
aries/aries_vcx/src/errors/mapping_wallet.rs 0.00% 20 Missing :warning:
...ries/aries_vcx_wallet/src/errors/mapping_others.rs 0.00% 15 Missing :warning:
...ries_vcx_wallet/src/wallet/indy/indy_did_wallet.rs 0.00% 13 Missing :warning:
aries/aries_vcx_wallet/src/wallet/utils.rs 0.00% 12 Missing :warning:
aries/aries_vcx_wallet/src/wallet/indy/mod.rs 0.00% 10 Missing :warning:
...s_vcx_wallet/src/wallet/indy/indy_record_wallet.rs 0.00% 7 Missing :warning:
...ies/aries_vcx_wallet/src/wallet/indy/indy_utils.rs 0.00% 7 Missing :warning:
... and 14 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1157 +/- ## ====================================== Coverage 0.05% 0.05% ====================================== Files 484 487 +3 Lines 24203 23966 -237 Branches 4490 4409 -81 ====================================== Hits 13 13 + Misses 24190 23953 -237 ``` | [Flag](https://app.codecov.io/gh/hyperledger/aries-vcx/pull/1157/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hyperledger) | Coverage Δ | | |---|---|---| | [unittests-aries-vcx](https://app.codecov.io/gh/hyperledger/aries-vcx/pull/1157/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hyperledger) | `0.05% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hyperledger#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

xprazak2 commented 8 months ago

Finally 🟢