hyperledger / aries-vcx

aries-vcx is set of crates to work with DIDs, DID Documents, DIDComm, Verifiable Credentials and Hyperledger Aries.
https://didcomm.org
Apache License 2.0
125 stars 83 forks source link

Feature/didpeer4 #1161

Closed Patrik-Stas closed 8 months ago

Patrik-Stas commented 8 months ago

Implement did:peer:4 ( see https://identity.foundation/peer-did-method-spec/#method-4-short-form-and-long-form ) as PeerDid<Numalgo4>

APIs:

DidPeer4EncodedDocument

PeerDid<Numalgo4>::long_form(&self) -> Result<Did, DidPeerError>

PeerDid<Numalgo4>::short_form(&self) -> Result<Did, DidPeerError>

PeerDid<Numalgo4>::hash(&self) -> Result<String, DidPeerError>

PeerDid<Numalgo4>::resolve_did_doc(&self) -> Result<DidDocument, DidPeerError>

codecov-commenter commented 8 months ago

Codecov Report

Attention: Patch coverage is 0% with 205 lines in your changes are missing coverage. Please review.

Project coverage is 0.05%. Comparing base (8715b95) to head (4923069). Report is 2 commits behind head on main.

Files Patch % Lines
...ods/did_peer/src/peer_did/numalgos/numalgo4/mod.rs 0.00% 55 Missing :warning:
...src/peer_did/numalgos/numalgo4/encoded_document.rs 0.00% 39 Missing :warning:
...id_core/did_parser_nom/src/did/parsing/did_core.rs 0.00% 21 Missing :warning:
..._core/did_methods/did_peer/src/peer_did/generic.rs 0.00% 13 Missing :warning:
did_core/did_parser_nom/src/did/parsing/did_sov.rs 0.00% 13 Missing :warning:
..._core/did_parser_nom/src/did/parsing/did_peer_4.rs 0.00% 11 Missing :warning:
did_core/did_methods/did_peer/src/resolver/mod.rs 0.00% 8 Missing :warning:
did_core/did_doc/src/schema/did_doc.rs 0.00% 7 Missing :warning:
...core/did_doc/src/schema/verification_method/mod.rs 0.00% 7 Missing :warning:
aries/aries_vcx_core/src/ledger/type_conversion.rs 0.00% 4 Missing :warning:
... and 13 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1161 +/- ## ======================================== - Coverage 0.05% 0.05% -0.01% ======================================== Files 483 485 +2 Lines 24188 24332 +144 Branches 4473 4511 +38 ======================================== Hits 13 13 - Misses 24175 24319 +144 ``` | [Flag](https://app.codecov.io/gh/hyperledger/aries-vcx/pull/1161/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hyperledger) | Coverage Δ | | |---|---|---| | [unittests-aries-vcx](https://app.codecov.io/gh/hyperledger/aries-vcx/pull/1161/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hyperledger) | `0.05% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hyperledger#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.