Closed Patrik-Stas closed 7 months ago
Attention: Patch coverage is 0%
with 141 lines
in your changes are missing coverage. Please review.
Project coverage is 0.05%. Comparing base (
09144f1
) to head (20c48fa
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
did:peer:4
in didexchange (producedid:peer:4
in outgoing messages for both requester and responder)did:peer:2
(well, or any other DID method we support)Additional updates:
DidDocument
:assertion_method_by_key(&self, id: &str)
verification_method_by_id(&self, id: &str)
key_agreement_by_id(&self, id: &str)
capability_invocation_by_id(&self, id: &str)
capability_delegation_by_id(&self, id: &str)
DidDocument
, generally following pattern:add_authentication(&mut self, method: VerificationMethodKind)
add_authentication_object(&mut self, method: VerificationMethod)
add_authentication_ref(&mut self, reference: DidUrl)
Fixes
contextualize_to_did_doc
which causesdid:peer:4
to not fully decodeError handling changes
PeerDid<Numalgo4>::short_form(&self)
does not returnResult
, but instead usesexpect()
which should never happens (see safety note in the code).DidPeer4ConstructionDidDocument::contextualize_to_did_doc(&self, did_peer_4: &PeerDid<Numalgo4>)
is now also usingpanic
upon conversion of DID type to URI type. Every DID is URI and therefore this should never panic. If panic occurs, it strictly indicates either: