search

hyperledger / aries-vcx

aries-vcx is set of crates to work with DIDs, DID Documents, DIDComm, Verifiable Credentials and Hyperledger Aries.
https://didcomm.org
Apache License 2.0
125 stars 83 forks source link

fix: did type in message crates #1179

Open GHkrishna opened 7 months ago

GHkrishna commented 7 months ago

Resolves https://github.com/hyperledger/aries-vcx/issues/1165

Use did_parser_nom's Did type in message crates instead of string so as to parse & verify DIDs upon message deserialization

Patrik-Stas commented 7 months ago

Hi @GHkrishna please have a look at my comment in your previous PR: https://github.com/hyperledger/aries-vcx/pull/1171#issuecomment-2035928469

Given things as they are, the code doesn't compile, the changes you made need more sync up across the codebase.

nain-F49FF806 commented 7 months ago

@GHkrishna In your local project directory, try running cargo clippy in the terminal. This will show up some of the things that you will need to do for your fix to be correct and complete.

Once you have taken care of the clippy suggestions, your code should compile.
We can then assist you further.

Best regards.