hyperledger / aries-vcx

aries-vcx is set of crates to work with DIDs, DID Documents, DIDComm, Verifiable Credentials and Hyperledger Aries.
https://didcomm.org
Apache License 2.0
125 stars 83 forks source link

Handle trust pings in the AATH backchannel #1254

Closed gmulhearn closed 4 months ago

gmulhearn commented 4 months ago

Close #1253

This adds handling for TrustPing, which solves the issue of connections not entering complete state when VCX is the connection inviter.

Results of ariesvcx-acapy manual runset of RFC0160

behave -D Acme=http://0.0.0.0:9020 -D Bob=http://0.0.0.0:9030 -t @RFC0160 -t ~@wip -t ~@RFC0434 -t ~@RFC0453 -t ~@RFC0211 -t ~@DIDExchangeConnection -t ~@Transport_Ws

Before

all failures.

After

(failures are due to running this with only 2 agents)

Failing scenarios:
  features/0160-connection.feature:52  Inviter Sends invitation for one agent second agent tries after connection
  features/0160-connection.feature:69  Inviter Sends invitation for one agent second agent tries during first share phase

0 features passed, 2 failed, 13 skipped
4 scenarios passed, 2 failed, 154 skipped
28 steps passed, 2 failed, 1353 skipped, 0 undefined