search

hyperledger / aries-vcx

aries-vcx is set of crates to work with DIDs, DID Documents, DIDComm, Verifiable Credentials and Hyperledger Aries.
https://didcomm.org
Apache License 2.0
125 stars 83 forks source link

Process prefixed DIDs in aries messages #627

Closed Patrik-Stas closed 2 years ago

Patrik-Stas commented 2 years ago

Currently aries-vcx assumes did in connection protocol public invitations, out of band protocol invitations, do not contain did:sov prefix. Equally, aries-vcx does generate aries messages which do not contain the prefix.

Useful context from @guijd3p in this post analyzing how this is treated by other implementations https://github.com/hyperledger/aries-vcx/issues/609#issuecomment-1292698710

Patrik-Stas commented 2 years ago

@guijd3p do I understand your proposal correct, to simply remap did:sov:abc12346 to -> abc12346 when processing public/oob invitations, and keep the inner layers of code intact?

Sounds fair to me. Thoughts @mirgee ?

We could add probably similar support for did:peer, but that could be treated as separate issue.

guijd3p commented 2 years ago

Hi @Patrik-Stas I have a doubt regarding the public invite, I made the implementation to read the prefix did:sov, but when performing the tests he could not retrieve the AriesServices, that is, when creating the public invite, should it save in the ledger?

guijd3p commented 2 years ago

I was having problems with my ledger, but yes it saves when an invite public is created