Open bobozaur opened 1 year ago
@bobozaur I would like to work on this issue could you assign it to me plz.
@bobozaur can you help me locate Attribute struct inside the file structure, i'am struggling to find it
@SumantxD My bad, the struct rename was already done but I was looking at an older branch when drafting this issue. I updated the issue description to match the main branch.
@bobozaur I have tried solving the issue here is the PR https://github.com/hyperledger/aries-vcx/pull/831
The attributes (
CredentialAttr
andPresentationAttr
) could benefit from handling thevalue
andmime-type
pair in a different manner. Right now both fields are deserialized and handling would have to be done based on whether aMimeType
is present or not.A better idea would be to use an
AttrValue
#[serde(flatten)]
enum with two variants:Plain { value: String }
Encoded { value: String, mime_type: MaybeKnown<MimeType> }
Note the
MaybeKnown
enum use, which would also be a beneficial addition in case we get a mime_type we don't recognize.Having the attribute value deserialized this way would make handling it easier since we can match and deduce that:
Plain
, it's just a string,Encoded
, it's a base64 encoded string that then has to be processed according to theMimeType
.Steps:
MimeType
inMaybeKnown
AttrValue
enum in both attribute types.