Closed neotheprogramist closed 8 months ago
seems to work . could we add a small description in the PR ?
Shouldn't we have a test in ipa-multipoint/src/test/java/org/hyperledger/besu/nativelib/ipa_multipoint/ for this method as well ?
Good with me. Thanks!
Good for me as well, thanks @neotheprogramist
Description
This pull request addresses a critical linking error encountered in the Hyperledger Besu native library. The issue came to light following a modification in the method invocation within the
PedersenHasher
class, whereLibIpaMultipoint.commit
was changed toLibIpaMultipoint.commit_root
. As a result of this change, ajava.lang.UnsatisfiedLinkError
is triggered when calling thecommit_root
method, with the error message:'byte[] org.hyperledger.besu.nativelib.ipamultipoint.LibIpaMultipoint.commit_root(byte[])'
.Proposed Fix
The fix proposed in this pull request involves renaming the
commit_root
method from snake_case to camelCase. This renaming aims to:Context
While other methods in the
LibIpaMultipoint
class, such ascommit
andpedersenHash
, continue to operate as expected, it is believed that the naming convention employed forcommit_root
may be contributing to the linking error.