search

hyperledger / besu-native

Apache License 2.0
12 stars 34 forks source link

chore!: Modify functionality of `commitRoot` to use `groupToField` #151

Closed kevaundray closed 4 months ago

kevaundray commented 5 months ago

Rationale

For the Java library, this will eventually reduce the API surface needed. commitRoot will essentially become a call to commitToScalar + groupToField.

This issue expands on the rationale: https://github.com/crate-crypto/rust-verkle/issues/86

There are some geth and go-verkle PRs which would be good to merge before merging this (Leaving this as a Draft while those are open)

kevaundray commented 5 months ago

Tests should be failing since hard coded test vectors for commitRoot were not updated

kevaundray commented 4 months ago

Closing as we don't want to modify commitRoot since mapToScalarField is not invertible