search

hyperledger / besu-native

Apache License 2.0
13 stars 36 forks source link

Bugfix/eip 196 edge case #185

Closed garyschulte closed 3 months ago

garyschulte commented 3 months ago

fix for a weird (imo) EIP-196 expectation that a malformed/incomplete g1 point should return an error if the X value is readable, but not in the field; whereas a malformed/incomplete g1 point will otherwise return 0

garyschulte commented 3 months ago

I'm not sure about the edge case. For me it does not make sense and we should try to find out whether that is the right behaviour.

This PR to resolve a reference test failure. I agree it is weird behavior. IMO all malformed inputs should return an error.

reference test fail: https://github.com/hyperledger/besu/actions/runs/9686194628/job/26728072192?pr=7262