hyperledger / besu

An enterprise-grade Java-based, Apache 2.0 licensed Ethereum client https://wiki.hyperledger.org/display/besu
https://www.hyperledger.org/projects/besu
Apache License 2.0
1.53k stars 849 forks source link

PrivateTransactionReceipt.toString() prints misleading info #2268

Closed macfarla closed 3 years ago

macfarla commented 3 years ago

PrivateTransactionReceipt.toString() is missing info eg https://app.circleci.com/pipelines/github/hyperledger/besu/8743/workflows/acf097ba-2e00-4288-9c38-5c26aedbc9f1/jobs/44907

Expecting:
  <TransactionReceipt{transactionHash='null', transactionIndex='0x0', blockHash='0x52b77d062ce62d477869ae4431cf5cbbcbc52e3dfde1b624182a0c91c94aad99', blockNumber='0x10', cumulativeGasUsed='null', gasUsed='null', contractAddress='null', root='null', status='null', from='null', to='null', logs=null, logsBloom='0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000', revertReason='null'}>
to be equal to:
  <TransactionReceipt{transactionHash='null', transactionIndex='null', blockHash='null', blockNumber='null', cumulativeGasUsed='null', gasUsed='null', contractAddress='null', root='null', status='null', from='null', to='null', logs=null, logsBloom='null', revertReason='null'}>
when recursively comparing field by field, but found the following difference:

eg field from - toString() is implemented on superclass TransactionReceipt but PrivateTransactionReceipt also has a
private final String from;

macfarla commented 3 years ago

this is actually a bug in web3j

vmichalik commented 3 years ago

should we raise a web3j ticket and close this?

antonydenyer commented 3 years ago

Done https://github.com/web3j/web3j/issues/1427

vmichalik commented 3 years ago

Cheers!