hyperledger / besu

An enterprise-grade Java-based, Apache 2.0 licensed Ethereum client https://wiki.hyperledger.org/display/besu
https://www.hyperledger.org/projects/besu
Apache License 2.0
1.51k stars 834 forks source link

Remove experimental flags related to the EIP 1559 #2568

Closed matkt closed 3 years ago

matkt commented 3 years ago

We need to clean the ExperimentalEIPs class by removing this flags

This was configurable when developing the EIP now the values have been defined in the spec and cannot change via a flags without creating a consensus bug issue on the mainnet

@Option(
      hidden = true,
      names = {"--Xeip1559-basefee-max-change-denominator"},
      arity = "1")
  public static Long basefeeMaxChangeDenominator = 8L;

  @Option(
      hidden = true,
      names = {"--Xeip1559-initial-base-fee"},
      arity = "1")
  public static Long initialBasefee = EIP1559_BASEFEE_DEFAULT_VALUE;

  @Option(
      hidden = true,
      names = {"--Xeip1559-slack-coefficient"},
      arity = "1")
  public static Long slackCoefficient = 2L;
garyschulte commented 3 years ago

resolved by https://github.com/hyperledger/besu/pull/2577 and https://github.com/hyperledger/besu/pull/2586