feat(transitions) - change also requesttimeoutseconds through transitions.

[rinor]

Description

Now that https://github.com/hyperledger/besu/pull/2902 is merged, it would be useful to have the possibility to change also requesttimeoutseconds through transitions.

Acceptance Criteria

existing functionality:

{
  "config": {
    ....
    "ibft2": {
      "epochlength": 30000,
      "blockperiodseconds": 2,
      "requesttimeoutseconds": 4
    },
    "transitions": {
      "ibft2": [
        {
          "block": 20,
      "blockperiodseconds": 4
    }
    ]
    }
  },
...
}

desired funtionality

{
  "config": {
    ....
    "ibft2": {
      "epochlength": 30000,
      "blockperiodseconds": 2,
      "requesttimeoutseconds": 4
    },
    "transitions": {
      "ibft2": [
        {
          "block": 20,
      "blockperiodseconds": 4,
      "requesttimeoutseconds": 8
    }
    ]
    }
  },
...
}

[siladu]

Hi @rinor, thanks for creating this issue. Agree this would be nice to have and we'll add to our backlog, but I can't give you a timeline for when we'll get to it unfortunately. Community contributions most definitely welcome, it would be a quick one for us to review I think.

In the meantime, as you may already be aware, you can workaround this by changing the value in config/ibft2 directly (rather than via transitions) and then restarting the whole network. This only works for this particular config item because changing it won't invalidate previous blocks.

[rinor]

Thank you. Will retest by changing the config without transitions and report back.

[rinor]

Closing this since the mentioned config change works properly.

[siladu]

Hi @rinor if you are OK with it, I'll reopen as this is the issue we are using in our backlog to track the feature request.