search

hyperledger / besu

An enterprise-grade Java-based, Apache 2.0 licensed Ethereum client https://wiki.hyperledger.org/display/besu
https://www.hyperledger.org/projects/besu
Apache License 2.0
1.48k stars 804 forks source link

Productionise Withdrawals WIP #4777

Closed siladu closed 1 year ago

siladu commented 1 year ago

Note: This issue (especially task 2) is strongly related to splitting the WIP branch into separate PRs: https://github.com/hyperledger/besu/issues/4776 It might be better to do this issue's tasks as part of each split out PR.

Tasks:

  1. Fill in the unit test gaps.
  2. Refactor, e.g. fold back in most of EngineForkChoiceUpdated and EngineForkChoiceUpdatedV2 code for each V2 class (should also check for recent changes to V1 methods)

Probably no need for integration or acceptance tests since we will have the hive tests, see https://github.com/hyperledger/besu/issues/4747

Unit tests can be implemented on the WIP branch for now: https://github.com/hyperledger/besu/pull/4552

siladu commented 1 year ago

This work has been split out into separate stories