search

hyperledger / besu

An enterprise-grade Java-based, Apache 2.0 licensed Ethereum client https://wiki.hyperledger.org/display/besu
https://www.hyperledger.org/projects/besu
Apache License 2.0
1.52k stars 841 forks source link

options summary should say "custom genesis" if --genesis-file is used #4880

Closed macfarla closed 1 year ago

macfarla commented 1 year ago

When I start besu with a custom genesis file, the options printer outer prints "Mainnet" which could be misleading

eg here I have a custom genesis file (even using isQuorum mode) and it shows "Network: Mainnet"

2023-01-04 11:57:00.321+10:00 | main | INFO  | Besu | Starting Besu
2023-01-04 11:57:01.025+10:00 | main | WARN  | Besu | Discovery disabled: bootnodes will be ignored.
2023-01-04 11:57:01.026+10:00 | main | WARN  | Besu | isQuorum mode in genesis file (GoQuorum-compatible privacy mode) has been deprecated, use --privacy-enabled instead.
2023-01-04 11:57:01.031+10:00 | main | WARN  | Besu | Permissions are disabled. Cannot enable PERM APIs when not using Permissions.
2023-01-04 11:57:01.117+10:00 | main | INFO  | Besu |
####################################################################################################
#                                                                                                  #
# Besu 23.1.0-RC1-dev-3634d304                                                                     #
#                                                                                                  #
# Configuration:                                                                                   #
# Network: Mainnet                                                                                 #
macfarla commented 1 year ago

This was my command line besu --config-file config/besu/besu1-quorum.conf

config file contains:

genesis-file="config/besu/genesis-goquorum.json"