Start a refactor to simplify the integration of Verkle into Besu. For this, I’ve made several PRs to facilitate the review, even though some are a bit more complicated to review than others.
The first one, which is already merged, added the prefix ‘forest’ to all the forest classes to improve code readability. :heavy_check_mark:
The second one, also already merged, was a refactor at the package level to have a package that groups forest and bonsai. :heavy_check_mark:
The third one will allow us to no longer have a single KeyValueStorage interface for all storage formats as this makes the code unreadable. I’ve made sure that each storage format has its own methods (for example, forest doesn’t have the ‘location’ field in its interface). I’ve also added a coordinator for the parts that need to call forest or bonsai without really knowing. It will allow for routing. But in most of the code, we know if we are in a bonsai or forest context, so having a generic interface is unnecessary. https://github.com/hyperledger/besu/pull/6209
The fourth one will allow for a refactor of bonsai to have common classes between Verkle and bonsai. A lot of things will be used, but we can’t use bonsai as it is. This refactor will therefore allow the addition of Verkle. Bonsai and Verkle will be a common package called ‘diffbased’, and inside it will have three packages (common, verkle, bonsai). Diffbased will be next to forest.
The last one will be the addition of Verkle trie log under a Verkle flag for now.
matkt
commented
7 months ago
Start a refactor to simplify the integration of Verkle into Besu. For this, I’ve made several PRs to facilitate the review, even though some are a bit more complicated to review than others.
The first one, which is already merged, added the prefix ‘forest’ to all the forest classes to improve code readability. :heavy_check_mark:
The second one, also already merged, was a refactor at the package level to have a package that groups forest and bonsai. :heavy_check_mark:
The third one will allow us to no longer have a single KeyValueStorage interface for all storage formats as this makes the code unreadable. I’ve made sure that each storage format has its own methods (for example, forest doesn’t have the ‘location’ field in its interface). I’ve also added a coordinator for the parts that need to call forest or bonsai without really knowing. It will allow for routing. But in most of the code, we know if we are in a bonsai or forest context, so having a generic interface is unnecessary. https://github.com/hyperledger/besu/pull/6209
The fourth one will allow for a refactor of bonsai to have common classes between Verkle and bonsai. A lot of things will be used, but we can’t use bonsai as it is. This refactor will therefore allow the addition of Verkle. Bonsai and Verkle will be a common package called ‘diffbased’, and inside it will have three packages (common, verkle, bonsai). Diffbased will be next to forest.
The last one will be the addition of Verkle trie log under a Verkle flag for now.
For example :