search

hyperledger / besu

An enterprise-grade Java-based, Apache 2.0 licensed Ethereum client https://wiki.hyperledger.org/display/besu
https://www.hyperledger.org/projects/besu
Apache License 2.0
1.48k stars 803 forks source link

Sonarqube runs with failed tests shouldn't be failed workflow runs #6987

Open jflo opened 4 months ago

jflo commented 4 months ago

If you look at the history of Sonarqube actions, they don't always pass, despite having done their analysis and published it correctly. I suspect this is due to flaky tests, flaking during the course of the build target.

Can we setup this action to only fail if there was a problem with sonar analysis or publishing?

joshuafernandes commented 2 months ago

Hi @macfarla @jflo :) Just wanted to get some context on this mate, if these are flaky tests wouldn't we be better of fixing them so they aren't flaky? Or should we remove sonarqube - if we mute the results, is there much point in running it?

jflo commented 2 months ago

Definitely don't want to mute the results. Reporting on flaky tests helps us triage them to determine if they should be fixed or removed, so we want to include flaky tests in sonarqube reports.