search

hyperledger / besu

An enterprise-grade Java-based, Apache 2.0 licensed Ethereum client https://wiki.hyperledger.org/display/besu
https://www.hyperledger.org/projects/besu
Apache License 2.0
1.49k stars 812 forks source link

Optionally load jemalloc #7047

Open amsmota opened 5 months ago

amsmota commented 5 months ago

Description

As an Developer/Devops/Tester, I want to enable/disable the use of jemalloc when starting Besu so that I can easily test performance with/without jemalloc and be able to start without jemalloc if there is a memory issue on startup.

Acceptance Criteria

Versions

Implementation

I was able to implement and test this feature by reusing the BESU_USING_JEMALLOC env var, with changes in the initial besu start script and a few lines in ConfigurationOverviewBuilder.

If set, BESU_USING_JEMALLOC=true will load jemalloc, if set to anything else it won't. If BESU_USING_JEMALLOC is not set at all it'll load it too (that is the existing behavior).

If enough people think this is useful I am ready to create a PR.

macfarla commented 4 months ago

@amsmota I think it would be great if you could do a PR for this

amsmota commented 4 months ago

I will. Thanks... 👍

@amsmota I think it would be great if you could do a PR for this

amsmota commented 4 months ago

Hi @macfarla, I opened the PR already, see above.

Thanks. 👍

amsmota commented 2 months ago

Hi @macfarla, @non-fungible-nelson, I merged the current main branch into my branch, and it created a new PR (see below). Can youse please review it and hopefully approve it?

Many thanks.

Cheers.

https://github.com/hyperledger/besu/pull/7424