EIP-3074 gas check - Githubissues

hyperledger / besu

An enterprise-grade Java-based, Apache 2.0 licensed Ethereum client https://wiki.hyperledger.org/display/besu

https://www.hyperledger.org/projects/besu

Apache License 2.0

1.44k stars 765 forks source link

EIP-3074 gas check #7111

Closed shemnon closed 2 months ago

shemnon commented 2 months ago

PR description

Check for gas very early in the operation.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

[ ] Checked out our contribution guidelines?
[ ] Considered documentation and added the doc-change-required label to this PR if updates are required.
[ ] Considered the changelog and included an update if required.
[ ] For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

[ ] unit tests: ./gradlew build
[ ] acceptance tests: ./gradlew acceptanceTest
[ ] integration tests: ./gradlew integrationTest
[ ] reference tests: ./gradlew ethereum:referenceTests:referenceTests

jflo commented 2 months ago

probably didn't intend to include all of the things in this pr?

shemnon commented 2 months ago

Oopsies. Fixed.

shemnon commented 2 months ago

Mooted by #7121