hyperledger / besu

An enterprise-grade Java-based, Apache 2.0 licensed Ethereum client https://wiki.hyperledger.org/display/besu
https://www.hyperledger.org/projects/besu
Apache License 2.0
1.44k stars 765 forks source link

remove recursion from confirmPivotBlockHeader #7126

Closed macfarla closed 1 month ago

macfarla commented 2 months ago

PR description

Remove recursion from confirmPivotBlockHeader in order to simplify.

Fixed Issue(s)

fixes #7109

Thanks for sending a pull request! Have you done the following?

Locally, you can run these tests to catch failures early:

macfarla commented 2 months ago

looks like the simplest thing is not entirely working -

Screenshot 2024-05-22 at 9 07 37 AM
macfarla commented 2 months ago

Actually the full burn-in looks much the same as current RC

Screenshot 2024-05-23 at 8 39 45 AM
macfarla commented 1 month ago

closing this since we are going with an alternative approach