DCO Check GitHub workflow - Githubissues

hyperledger / besu

An enterprise-grade Java-based, Apache 2.0 licensed Ethereum client https://wiki.hyperledger.org/display/besu

https://www.hyperledger.org/projects/besu

Apache License 2.0

1.43k stars 759 forks source link

DCO Check GitHub workflow #7179

Closed cdivitotawela closed 1 month ago

cdivitotawela commented 1 month ago

PR description

DCO App not working and needed to be disabled the check. Introducing DCO GitHub action workflow to validate the commit signatures.

Fixed Issue(s)

fixes #7175

Thanks for sending a pull request! Have you done the following?

[x] Checked out our contribution guidelines?
[ ] Considered documentation and added the doc-change-required label to this PR if updates are required.
[ ] Considered the changelog and included an update if required.
[ ] For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

[x] unit tests: ./gradlew build
[x] acceptance tests: ./gradlew acceptanceTest
[x] integration tests: ./gradlew integrationTest
[x] reference tests: ./gradlew ethereum:referenceTests:referenceTests

cdivitotawela commented 1 month ago

the dco workflow failed because its not in the list of "allowed" workflow actions. https://github.com/hyperledger/besu/actions/runs/9378991548

How can we request to allow the action?

ryjones commented 1 month ago

DCO is working now.