Move traceEndTransaction after coinbase refund, add self destruct set to the method - Githubissues

hyperledger / besu

An enterprise-grade Java-based, Apache 2.0 licensed Ethereum client https://wiki.hyperledger.org/display/besu

https://www.hyperledger.org/projects/besu

Apache License 2.0

1.43k stars 759 forks source link

Move traceEndTransaction after coinbase refund, add self destruct set to the method #7188

Closed daniellehrner closed 3 weeks ago

daniellehrner commented 1 month ago

PR description

Fix for traceEndTransaction not considering the coinbase refund, added self destruct set

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

[x] Checked out our contribution guidelines?
[x] Considered documentation and added the doc-change-required label to this PR if updates are required.
[ ] Considered the changelog and included an update if required.
[x] For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

[x] unit tests: ./gradlew build
[ ] acceptance tests: ./gradlew acceptanceTest
[ ] integration tests: ./gradlew integrationTest
[ ] reference tests: ./gradlew ethereum:referenceTests:referenceTests