hyperledger / besu

An enterprise-grade Java-based, Apache 2.0 licensed Ethereum client https://wiki.hyperledger.org/display/besu
https://www.hyperledger.org/projects/besu
Apache License 2.0
1.43k stars 759 forks source link

Snapserver responses to return at least one response #7190

Closed jframe closed 1 week ago

jframe commented 1 month ago

PR description

The snap server responses must return at least one response item if the data can be retrieved according to the spec https://github.com/ethereum/devp2p/blob/master/caps/snap.md. This applies to all the request types.

After making this change all the GetByteCodes hive tests are passing. Note still need to make a change to hive testsuite to enable snapserver before this will be seen.

Fixed Issue(s)

Part of #7197

Thanks for sending a pull request! Have you done the following?

Locally, you can run these tests to catch failures early: