fix(test): Fix dns daemon periodic test - Githubissues

hyperledger / besu

An enterprise-grade Java-based, Apache 2.0 licensed Ethereum client https://wiki.hyperledger.org/display/besu

https://www.hyperledger.org/projects/besu

Apache License 2.0

1.43k stars 757 forks source link

fix(test): Fix dns daemon periodic test #7200

Closed usmansaleem closed 3 weeks ago

usmansaleem commented 3 weeks ago

PR description

fix(test): Fix dns daemon periodic test. Increase second run to 3 seconds

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

[x] Checked out our contribution guidelines?
[x] Considered documentation and added the doc-change-required label to this PR if updates are required.
[x] Considered the changelog and included an update if required.
[x] For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

[x] unit tests: ./gradlew build
[x] acceptance tests: ./gradlew acceptanceTest
[x] integration tests: ./gradlew integrationTest
[x] reference tests: ./gradlew ethereum:referenceTests:referenceTests

macfarla commented 3 weeks ago

@usmansaleem the failure I'm seeing is line 91

DNSDaemonTest > Test DNS Daemon with periodic lookup to a mock DNS server FAILED
    java.lang.AssertionError at VertxExtension.java:205
        Caused by: java.lang.AssertionError at DNSDaemonTest.java:91

macfarla commented 3 weeks ago

created #7201 think we need to disable this test until it can be fixed