search

hyperledger / besu

An enterprise-grade Java-based, Apache 2.0 licensed Ethereum client https://wiki.hyperledger.org/display/besu
https://www.hyperledger.org/projects/besu
Apache License 2.0
1.43k stars 757 forks source link

Update limit trie logs validation message for sync-mode=FULL #7279

Open siladu opened 5 days ago

siladu commented 5 days ago

Cannot enable --bonsai-limit-trie-logs-enabled with sync-mode FULL. You must set --bonsai-limit-trie-logs-enabled=false or use a different sync-mode

besu --sync-mode=full

BUILD SUCCESSFUL in 14s
95 actionable tasks: 49 executed, 46 up-to-date
2024-06-28 16:24:41.772+10:00 | main | INFO  | Besu | Starting Besu
2024-06-28 16:24:42.441+10:00 | main | ERROR | Besu | Failed to start Besu
picocli.CommandLine$ParameterException: Cannot enable --bonsai-limit-trie-logs-enabled with sync-mode FULL. You must set --bonsai-limit-trie-logs-enabled=false or use a different sync-mode
    at org.hyperledger.besu.cli.options.stable.DataStorageOptions.validate(DataStorageOptions.java:149)
    at org.hyperledger.besu.cli.BesuCommand.validateDataStorageOptions(BesuCommand.java:1579)
    at org.hyperledger.besu.cli.BesuCommand.validateOptions(BesuCommand.java:1546)
    at org.hyperledger.besu.cli.BesuCommand.run(BesuCommand.java:1166)
    at picocli.CommandLine.executeUserObject(CommandLine.java:2026)
    at picocli.CommandLine.access$1500(CommandLine.java:148)
    at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461)
    at picocli.CommandLine$RunLast.handle(CommandLine.java:2453)
    at picocli.CommandLine$RunLast.handle(CommandLine.java:2415)
    at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273)
    at picocli.CommandLine$RunLast.execute(CommandLine.java:2417)
    at picocli.CommandLine.execute(CommandLine.java:2170)
    at org.hyperledger.besu.cli.BesuCommand.lambda$createExecuteTask$1(BesuCommand.java:1099)
    at picocli.CommandLine.execute(CommandLine.java:2170)
    at org.hyperledger.besu.cli.BesuCommand.lambda$createPluginRegistrationTask$2(BesuCommand.java:1109)
    at picocli.CommandLine.execute(CommandLine.java:2170)
    at org.hyperledger.besu.cli.util.ConfigDefaultValueProviderStrategy.execute(ConfigDefaultValueProviderStrategy.java:58)
    at picocli.CommandLine.execute(CommandLine.java:2170)
    at org.hyperledger.besu.cli.BesuCommand.executeCommandLine(BesuCommand.java:1136)
    at org.hyperledger.besu.cli.BesuCommand.parse(BesuCommand.java:1078)
    at org.hyperledger.besu.Besu.main(Besu.java:41)
Cannot enable --bonsai-limit-trie-logs-enabled with sync-mode FULL. You must set --bonsai-limit-trie-logs-enabled=false or use a different sync-mode
matkt commented 5 days ago

it seems this PR is also touching this part https://github.com/hyperledger/besu/pull/7140/files/7bd09e3ee2ca05298469e7020b037091f3777931#diff-694f097ee7fb3140c34f4aed55d05b024c8faf509b09e71643d16ed68e1db67bL146, maybe we have to chose between this two modification ?

matthew1001 commented 1 day ago

LGTM @siladu

@matkt that change has been removed from https://github.com/hyperledger/besu/pull/7140 now