hyperledger / besu

An enterprise-grade Java-based, Apache 2.0 licensed Ethereum client https://wiki.hyperledger.org/display/besu
https://www.hyperledger.org/projects/besu
Apache License 2.0
1.49k stars 815 forks source link

Revert "Dagger controller tests (#7341)" #7497

Closed fab-10 closed 1 month ago

fab-10 commented 1 month ago

This reverts commit 38a025b8708f2c8f0daa31db1f30e995d9d15dd8.

PR description

Reverting Dagger for ATs since it is breaking ATs for plugins, I tried to fix but it is not trivial, the WIP is in this branch.

Main issues with plugins ATs are: extraCliOptions are not parsed, and configuration and service objects are not singletons, but are created multiple times with the effect that different part of code see different things.

FYI: @jflo

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

Locally, you can run these tests to catch failures early: