search

hyperledger / besu

An enterprise-grade Java-based, Apache 2.0 licensed Ethereum client https://wiki.hyperledger.org/display/besu
https://www.hyperledger.org/projects/besu
Apache License 2.0
1.53k stars 849 forks source link

Remove temporary/experimental flag `--Xsnapsync-bft-enabled` #7924

Open matthew1001 opened 1 week ago

matthew1001 commented 1 week ago

Our testing shows that this is stable and hasn't shown any issues since being introduced as an experimental option.

It can be ~moved out of the experimental options have the X prefix dropped, and be added to the Besu docs.~ removed entirely

pullurib commented 1 week ago

I can take care of this, please assign

matthew1001 commented 1 week ago

@pullurib I think I should have named this "Remove the experimental --Xsnapsync-bft-enabled flag. We added it as a way to turn BFT snap sync on and off while we tested the function. Now that we're happy it works, I think we want to remove the flag entirely, and then I think we can just remove the BesuCommand.validateConsensusSyncCompatibilityOptions() function as well.