search

hyperledger / cacti

Hyperledger Cacti is a new approach to the blockchain interoperability problem
https://wiki.hyperledger.org/display/cactus
Apache License 2.0
338 stars 277 forks source link

fix(iroha-connector): make compareAndSetAccountDetail accept correct parameters #1265

Open hanxu12 opened 3 years ago

hanxu12 commented 3 years ago

Depends on #1957

Describe the bug

One argument for compareAndSetAccountDetail, check_empty, is not dealt with inside the plugin-ledger-connector-iroha.ts file. The run-transaction test case also fail to use this argument. Moreover, the old_value argument should be optional, but it is a mandatory argument at this moment. Please refer to the official Iroha doc for description of compareAndSetAccountDetail.

To Reproduce

Check packages/cactus-plugin-ledger-connector-iroha/src/main/typescript/plugin-ledger-connector-iroha.ts file. Looking for the case of compareAndSetAccountDetail.

Expected behavior

Still runs, but it does not follow behaviors set by the official document.

Logs/Stack traces

N/A

Screenshots

image.png

Cloud provider or hardware configuration:

N/A

Operating system name, version, build:

N/A

Hyperledger Cactus release version or commit (git rev-parse --short HEAD):

0.9.0

Hyperledger Cactus Plugins/Connectors Used

Iroha

Additional context

github-actions[bot] commented 2 years ago

This PR/issue depends on: