hyperledger / caliper

A blockchain benchmark framework to measure performance of multiple blockchain solutions https://wiki.hyperledger.org/display/caliper
https://hyperledger.github.io/caliper/
Apache License 2.0
650 stars 403 forks source link

docker monitor remote monitoring bugfix #1499

Closed ghost closed 1 year ago

ghost commented 1 year ago

Checklist

Issue/User story

1493

Steps to Reproduce

  1. Add target remote docker container to monitoring in test config
  2. Run Caliper targeting the remote docker

Existing issues

How do I measure the performance of remote docker container in hyperledger caliper?

Design of the fix

Removed .remote in line 75 of monitor-docker.js, was likely a typo that was just missed since filterName has no property named remote

Validation of the fix

Ran a remote monitoring with good results report.zip

codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@d4c5939). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1499   +/-   ##
=======================================
  Coverage        ?   55.89%           
=======================================
  Files           ?      105           
  Lines           ?     4507           
  Branches        ?      688           
=======================================
  Hits            ?     2519           
  Misses          ?     1435           
  Partials        ?      553           
Flag Coverage Δ
caliper-core 44.98% <0.00%> (?)
caliper-fabric 80.46% <0.00%> (?)
generator-caliper 83.62% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.