Delete logo image stored in repo since it fetches from an external link

PrathamSikka24 commented 5 months ago

Title: Add Missing Hyperledger Fabric Logo

Checklist

[x] A link to the issue/user story that the pull request relates to
[x] How to recreate the problem without the fix
[x] Design of the fix
[x] How to prove that the fix works
[ ] Automated tests that prove the fix keeps on working
[x] Documentation - any JSDoc, website, or Stackoverflow answers?

Issue/User story

This pull request addresses the issue where the Hyperledger Fabric logo was not displayed on the landing page, as described in issue #1531 .

Steps to Reproduce

Navigate to the Hyperledger Caliper landing page.
Scroll down to the "Supported Blockchains" section.
Notice the absence of the Hyperledger Fabric logo, with only the alt text visible.

Existing issues

[x] GitHub Issues Related issue: link to the GitHub issue you created

Design of the fix

The fix involved adding the missing logo image to the assets directory and updating the HTML source to point to the correct image file location. The previous image no longer existed.

Validation of the fix

The fix was validated locally by refreshing the landing page and confirming that the Hyperledger Fabric logo is now displayed correctly.

Automated Tests

No automated tests were added as this fix is related to the static content of the website.

What documentation has been provided for this pull request

The change is self-documenting; the addition of the image file is the only update required.

davidkel commented 5 months ago

@PrathamSikka24 many thanks for the PR, unfortunately the commit isn't signed so we can't do anything with it. Please could you sign the commit and repush ?

PrathamSikka24 commented 5 months ago

@davidkel Thank you for bringing that to my notice. I've signed and re-pushed the commit. Please review it and let me know if anything else needs to be done.

PrathamSikka24 commented 5 months ago

We can reference the logo directly from the Hyperledger Fabric repo. However, the image in the link has a grey background, unlike our other UI images(logos of Hyperledger Besu, Ethereum), which are transparent. Could we find a transparent version or adapt this one?

For now, I have committed the change as you've suggested. Please let me know in case of anything else.

PrathamSikka24 commented 5 months ago

We can reference the logo directly from the Hyperledger Fabric repo. However, the image in the link has a grey background, unlike our other UI images(logos of Hyperledger Besu, Ethereum), which are transparent. Could we find a transparent version or adapt this one?

I have incorporated the necessary suggestion for the image link. I apologize for mistakenly making an extra PR; please don't mind that. Do tell me if anything else needs to be done.

hyperledger / caliper