hyperledger / caliper

A blockchain benchmark framework to measure performance of multiple blockchain solutions https://wiki.hyperledger.org/display/caliper

https://hyperledger.github.io/caliper/

Apache License 2.0

651 stars 404 forks source link

Remove Caliper-gui-server packages and Caliper-gui-dashboard packages #1538 #1540

Closed vinayakjaas closed 5 months ago

vinayakjaas commented 5 months ago

Checklist

[x] A link to the issue/user story that the pull request relates to
[x] How to recreate the problem without the fix
[x] Design of the fix
[x] How to prove that the fix works
[x] Automated tests that prove the fix keeps on working
[ ] Documentation - any JSDoc, website, or Stackoverflow answers?

Issue/User story

1538

Steps to Reproduce

1. 2. 3. 4.

Existing issues

Design of the fix

Validation of the fix

Automated Tests

What documentation has been provided for this pull request

davidkel commented 5 months ago

@vinayakjaas The build has failed, you will need to fix the build. I highly recommend running builds locally first before submitting PRs to ensure you submit a clean PR. Another option would be to mark the PR draft it you want to see the results of the build first or you think you will need to update the PR. We try to keep PRs down to a single commit if we can so if you do modify a PR try not to add more commits or squash your commits before you submit the PR.

vinayakjaas commented 5 months ago

Hey @davidkel Sorry for the inconvenience. I've resolved the build error. Thank you for guiding me—it's a good practice to run builds locally before PRs. I'll ensure to follow this in the future. Please review my PR Thank you