search

hyperledger / caliper

A blockchain benchmark framework to measure performance of multiple blockchain solutions https://wiki.hyperledger.org/display/caliper
https://hyperledger.github.io/caliper/
Apache License 2.0
642 stars 403 forks source link

Remove collection of node gc stats in prometheus #1545

Closed davidkel closed 2 months ago

davidkel commented 2 months ago

reasons for this

  1. we have never documented the metrics
  2. not sure how much use it is anyway
  3. was using an old version of gc-stats which is now unmaintained and has security issues
  4. replacement version of gc-stats is maintained by a single person who controls the binary builds available so is a dangerous thing to rely on
  5. it has no pure javascript fallback therefore requires caliper to pull down or build a binary module (meaning you need python and compilers installed) which will also be dependent on the version of node being used.
ryjones commented 2 months ago

@davidkel I think you can merge now. If you can't, please let me know and I'll merge it

davidkel commented 2 months ago

thanks @ryjones much appreciated