Try to enable go lint with options

hyperledger / fabric-admin-sdk

Fabric SDK for Admin Capability services

Apache License 2.0

31 stars 19 forks source link

Try to enable go lint with options #117

Open SamYuan1990 opened 1 year ago

SamYuan1990 commented 1 year ago

#- varcheck
  #- gocyclo
  #- bodyclose
  #- misspell
  #- nakedret
  #- unconvert
  # - goconst
  # - gocritic
  # - noctx
  # - whitespace
  # - dupl

to improve our code quantity with lint options above.

SamYuan1990 commented 1 year ago

@channingduan , could you please take a look at this issue?

bestbeforetoday commented 1 year ago

Just for reference, the current set of linters being run (in addition to staticcheck) are:

errcheck
gofmt
goimports
gosec
gosimple
govet
ineffassign
typecheck
unused

The active linters are configured in .golangci.yml. See the golangci-lint documentation for available linters.

SamYuan1990 commented 1 year ago

Just for reference, the current set of linters being run (in addition to staticcheck) are:

errcheck

gofmt

goimports

gosec

gosimple

govet

ineffassign

typecheck

unused

The active linters are configured in .golangci.yml. See the golangci-lint documentation for available linters.

thanks a lot for comments, updated scope.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.