search

hyperledger / fabric-admin-sdk

Fabric SDK for Admin Capability services
Apache License 2.0
31 stars 19 forks source link

update document and release page CI #121

Closed SamYuan1990 closed 1 year ago

SamYuan1990 commented 1 year ago

update read me document and add release page CI prepare for v0.0.0 release.

bestbeforetoday commented 1 year ago

Just for reference, the release process for fabric-gateway is documented here. The update of version numbers is there only to support the Node and Java releases that are produced alongside the Go release, and for publishing snapshot (development) releases of those Node and Java packages. The actual release is driven by creating the GitHub release in the GitHub web UI, as described in the Create release section. The creation of the GitHub release and accompanying Git tag then drives a release workflow to do automated publishing of that release.

You seem to be proposing a release process where a Git tag drives a release workflow, which in turn creates a GitHub release. The fabric-gateway process is almost the reverse, with the GitHub release creation driving the Git tag and publish workflow.

There is nothing to do in the fabric-gateway release workflow for Go code; only for Node and Java. If you are only looking to release Go for now, maybe you don't need a release workflow at all. Just create a GitHub release and let it tag the code.

SamYuan1990 commented 1 year ago

Just for reference, the release process for fabric-gateway is documented here. The update of version numbers is there only to support the Node and Java releases that are produced alongside the Go release, and for publishing snapshot (development) releases of those Node and Java packages. The actual release is driven by creating the GitHub release in the GitHub web UI, as described in the Create release section. The creation of the GitHub release and accompanying Git tag then drives a release workflow to do automated publishing of that release.

You seem to be proposing a release process where a Git tag drives a release workflow, which in turn creates a GitHub release. The fabric-gateway process is almost the reverse, with the GitHub release creation driving the Git tag and publish workflow.

There is nothing to do in the fabric-gateway release workflow for Go code; only for Node and Java. If you are only looking to release Go for now, maybe you don't need a release workflow at all. Just create a GitHub release and let it tag the code.

ok, I will create 1st tag for golang without this PR later.