search

hyperledger / fabric-admin-sdk

Fabric SDK for Admin Capability services
Apache License 2.0
31 stars 19 forks source link

Update dependencies to address GO-2024-2687 #192

Closed bestbeforetoday closed 3 months ago

bestbeforetoday commented 3 months ago

Disable automatic update of dependencies that do not address security vulnerabilities. These updates appear to regularly mess up the Go dependencies (go.mod/go.sum).

grpc.Dial() and grpc.DialContext() are deprecated in current gRPC versions, and replaced by grpc.NewClient().

bestbeforetoday commented 3 months ago

LGTM, btw @bestbeforetoday , grpc changes some behaviors in the NewClient, any impact?

One place in the code used grpc.DialContent(). This tries to establish the network connection immediately rather than waiting until the connection is actually used to make a request. In practice I don't think this makes any noticeable difference. It just means that an existing network issue will cause an error when a request is made instead when the connection is created. A network issue can occur at any time so errors could always happen when a request is made, even if the initial connect was successful.