search

hyperledger / fabric-admin-sdk

Fabric SDK for Admin Capability services
Apache License 2.0
31 stars 19 forks source link

Nominate channing duan #74

Closed SamYuan1990 closed 1 year ago

SamYuan1990 commented 1 year ago

Nominate @channingduan as maintainer for this project.

duan helps with init features of golang code.

ref to https://github.com/hyperledger/fabric-admin-sdk/pulls?q=is%3Apr+is%3Aclosed+author%3Achanningduan

Signed-off-by: Sam Yuan yy19902439@126.com

SamYuan1990 commented 1 year ago

fix #70 (add closing keyword)

SamYuan1990 commented 1 year ago

The list should be sorted in some way. It is currently sorted alphabetically (by first name), which would mean that Channing would go at the top of the list. Or you could choose an alternative sorting and re-order all the entries to match that

ok , it sorted by alphabetically for now.

SamYuan1990 commented 1 year ago

Looks good to me. We'll also need to raise an issue with Hyperledger to have Channing added to the @hyperledger/fabric-admin-sdk-maintainers team:

https://github.com/hyperledger/governance/issues/new/choose

I think once @davidkhala gives his approval and merged this PR. We can raise an issue with Hyperledger to have Channing added to the @hyperledger/fabric-admin-sdk-maintainers team.

davidkhala commented 1 year ago

LGTM. I prefer use personal than company email for contribution.