search

hyperledger / fabric-admin-sdk

Fabric SDK for Admin Capability services
Apache License 2.0
31 stars 19 forks source link

add update channel #79

Closed channingduan closed 1 year ago

channingduan commented 1 year ago

add channel config update implementation testing code

see issue #30 and update #55

bestbeforetoday commented 1 year ago

There is a build failure caused (I think) by a new static check release, not by this PR. I have merged a fix so you if you rebase on the current main branch, your PR should pass the build. Alternatively, you could review/merge #83 (which tidies up the build pipeline) and rebase on top of that.

Edit: I've enabled required status checks for PRs that use the output from #83 so that change should go in before rebase.

channingduan commented 1 year ago

There is a build failure caused (I think) by a new static check release, not by this PR. I have merged a fix so you if you rebase on the current main branch, your PR should pass the build. Alternatively, you could review/merge #83 (which tidies up the build pipeline) and rebase on top of that.

Edit: I've enabled required status checks for PRs that use the output from #83 so that change should go in before rebase.

OK~ I have rebase done,looks like it's ok now.

SamYuan1990 commented 1 year ago

@bestbeforetoday @channingduan , is this PR ready for merge?

bestbeforetoday commented 1 year ago

@bestbeforetoday @channingduan , is this PR ready for merge?

The commit history of this PR looks to be a bit of a mess, and it is showing conflicts that would prevent a simple rebase on main. I will see if I can unpick some of the issues so we can get this and not hold up other PRs.

bestbeforetoday commented 1 year ago

I have rebased and squashed this change into a single commit on top of the current state of the main branch. I pushed that back to the PR branch so the Files changed for this PR now just shows the changes to be merged. There is a backup of exactly what was in the PR branch before I made these changes here.