hyperledger / fabric-admin-sdk

Fabric SDK for Admin Capability services
Apache License 2.0
31 stars 19 forks source link

Refactor chaincode commit #87

Closed bestbeforetoday closed 1 year ago

bestbeforetoday commented 1 year ago
bestbeforetoday commented 1 year ago

I hope we can clean up useless comments before merge. Or you can go ahead with merge it then we will have another PR for clean up.

I have merged so other changes can be based on top of it. It would be good to have a follow-up PR that takes the channel configuration test code I had to comment out and perhaps moves it to a separate end-to-end test, which configures another channel. That would allow the chaincode deployment and channel config code to both continue being tested until anchor peer configuration is added so we have a complete end-to-end capability.

If it is possible to configure anchor peers with the current implementation, then please do go ahead and add that into the end-to-end test code and we can go back to using the channel config API instead of having the network.sh script create the channel.