search

hyperledger / fabric-chaincode-go

Hyperledger Fabric Packages for Go Chaincode
https://pkg.go.dev/github.com/hyperledger/fabric-chaincode-go
Apache License 2.0
138 stars 133 forks source link

[FAB-16948] Fabric go cid interface enhancement #9

Closed SamYuan1990 closed 5 years ago

SamYuan1990 commented 5 years ago

[FAB-16948] Fabric go cid interface enhancement

Signed-off-by: SamYuan yy19902439@126.com

Just did same changes with https://gerrit.hyperledger.org/r/c/fabric/+/34114/1/core/chaincode/shim/ext/cid/cid_test.go#120 https://gerrit.hyperledger.org/r/c/fabric/+/34114/1/core/chaincode/shim/ext/cid/cid.go#106

Follow up with comments in https://jira.hyperledger.org/browse/FAB-16948

denyeart commented 5 years ago

@SamYuan1990 Since the release-1.4 commit had already been merged in fabric using your original approach (via your gerrit CR contribution), please do a second gerrit CR in fabric release-1.4 to match the new approach. Sorry you have to do both a PR and a Gerrit CR to different repos/branch in this case... you got caught in the middle of our transition from Gerrit to Github.

SamYuan1990 commented 5 years ago

@denyeart ....well, I will create the CR, and, please ask the someone who response to use this PR code instead of Gerrit one. As this is the latest.

Generally speaking, I just commit to make the files contents same. However, obviously, the git commit history are diff.

https://gerrit.hyperledger.org/r/c/fabric/+/34159/2