search

hyperledger / fabric-chaincode-java

Hyperledger Fabric Contract and Chaincode implementation for Java
https://hyperledger.github.io/fabric-chaincode-java/
Apache License 2.0
304 stars 207 forks source link

upgrade otel to latest version #236

Closed atoulme closed 1 year ago

atoulme commented 2 years ago

Signed-off-by: Antoine Toulme antoine@lunar-ocean.com

mbwhite commented 2 years ago

@atoulme sorry didn't get to this last week.

Could you explain a bit please about the changes to the chaincodeserver start and the 'blocking'?
Is this related to the update to open telemetry?

atoulme commented 2 years ago

Those changes are needed because the tests kept breaking randomly. Instead of using a Thread.sleep in tests, I use a synchronous non-blocking start method, allowing us to test.

ryjones commented 1 year ago

@atoulme - looking at the current state of main, could you resolve the conflict?

bestbeforetoday commented 1 year ago

OpenTelemetry was updated to a newer version as part of #314 so I am going to close this.