search

hyperledger / fabric-chaincode-java

Hyperledger Fabric Contract and Chaincode implementation for Java
https://hyperledger.github.io/fabric-chaincode-java/
Apache License 2.0
304 stars 207 forks source link

Fix TLS setup for chaincode server #266

Closed C0rWin closed 1 year ago

C0rWin commented 1 year ago

There was a typo which copied certificate file path into the TLS private key file property. This commit fixes the issue.

Change-Id: I41e4d3ecbf48a465b7a42fdfecc21cdb90ce8f1f Signed-off-by: Artem Barger artem@bargr.net

C0rWin commented 1 year ago

@mbwhite can you please take a look? I am not able to setup TLS w/o this fix. Just noted you have another outstanding commit, though with similar issue: https://github.com/hyperledger/fabric-chaincode-java/pull/222/files#diff-33be50b40f1da46b8e8773332a638811becc4f032c632bfb664bae875dd8f7ebR542

do you want me to incorporate the change into it and merge, then we can close the current one?

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

mbwhite commented 1 year ago

Hi @C0rWin thanks for the fix!

Release 2.5 is starting the process of going out; would you mind creating a PR for release-2.5 branch... the main branch is picking up the v3.0 updated branch and we need to update the tests to cope with some of the breaking changes in there.

C0rWin commented 1 year ago

Hi @C0rWin thanks for the fix!

Release 2.5 is starting the process of going out; would you mind creating a PR for release-2.5 branch... the main branch is picking up the v3.0 updated branch and we need to update the tests to cope with some of the breaking changes in there.

@mbwhite https://github.com/hyperledger/fabric-chaincode-java/pull/267