search

hyperledger / fabric-gateway

Go, Node and Java client API for Hyperledger Fabric v2.4+
https://hyperledger.github.io/fabric-gateway/
Apache License 2.0
150 stars 88 forks source link

Removed Node 16 support and added Node 20 #623

Closed Shiva953 closed 1 year ago

Shiva953 commented 1 year ago

Ref. #614 #613

bestbeforetoday commented 1 year ago

Thank you for the contribution. As mentioned in #614, we cannot remove support for Node 16 until after it reaches end-of-life on 2023-09-11.

The Node implementation still needs to be built for the minimum supported Node release, not the latest. The changes to the tsconfig.json to build for a newer Node version will not work without also updating the devDependencies in package.json.

Pull request #621 is already open to include Node 20 in the test matrix. I am wary of using Node 20 for any of the other build steps until after it is actually promoted to active LTS status.

Since this PR contains only changes that cannot yet be merged, and changes that duplicate existing PRs, I am going to close this for now. Once Node 20 is promoted to an active LTS release, I would be happy for you to contribute the changes to remove Node 16 and update the TypeScript compile options to target Node 18. This would need to be applied to both the Node implementation and the Node scenario tests.