chaincode-container helper does not work with Fabric 2.0 anymore

hyperledger / fabric-private-chaincode

FPC enables Confidential Chaincode Execution for Hyperledger Fabric using Intel SGX.

Apache License 2.0

160 stars 91 forks source link

chaincode-container helper does not work with Fabric 2.0 anymore #244

Closed mbrandenburger closed 4 years ago

mbrandenburger commented 4 years ago

With Fabric 1.4 utils/fabric/get-fabric-container-name.go uses ccintf.CCID to build the chaincode container name. However, this got removed with Fabric 2.0. See here

A quick patch could be:

    ccid := *ccName + ":" + *ccVersion
    name, _ := vm.GetVMNameForDocker(ccid)

Maybe this helper will eventually go away as we move towards external builders.

g2flyer commented 4 years ago

this helper should go away with the external builder and the removal of the switcheroo. So quick patch seems fine although we should add a comment on from where we got that code fragment (presumably <fabric-core.git>/core/chaincode/chaincode_support.go:LaunchInProc() ?) ..