hyperledger / fabric-private-chaincode

FPC enables Confidential Chaincode Execution for Hyperledger Fabric using Intel SGX.
Apache License 2.0
159 stars 91 forks source link

CI, Golint Check before building PR #729

Open chenchanglew opened 12 months ago

chenchanglew commented 12 months ago

Is your feature request related to a problem? Please describe. I had a Golang lint error after 20 minutes of docker build. Maybe we can add a new Golint checking before building docker image in CI.

Describe the solution you'd like Current CI Flow:

Set up job
Run actions/checkout@v4
Run dorny/paths-filter@v2
build dev image
fetch dev image
run make inside dev container
....

Suggest CI Flow:

Set up job
Run actions/checkout@v4
Run dorny/paths-filter@v2
golint checking
build dev image
fetch dev image
run make inside dev container
....

Describe alternatives you've considered Or any step before run make inside dev container

mbrandenburger commented 12 months ago

Need to check if we can run the check target before build.

The current order is defined here: https://github.com/hyperledger/fabric-private-chaincode/blob/main/build.mk#L20

mbrandenburger commented 11 months ago

Another issue is that we need to generate proto files otherwise the linter is not happy with go and cpp code :/