hyperledger / fabric-sdk-go

https://wiki.hyperledger.org/display/fabric
Apache License 2.0
911 stars 508 forks source link

Not able to build the Go file #217

Open dinesh-ngpws opened 2 years ago

dinesh-ngpws commented 2 years ago

For past few months we are using a go version (Go 1.16.6) ,we are able to build go code without any issue. But yesterday we tried to build the same code with same version of go ,we are facing this issue while building.

The error is :
github.com/hyperledger/fabric-sdk-go/internal/github.com/hyperledger/fabric/core/operations
../../golang/pkg/mod/github.com/hyperledger/fabric-sdk-go@v1.0.0/internal/github.com/hyperledger/fabric/core/operations/system.go:225:23: not enough arguments in call to s.statsd.SendLoop
        have (<-chan time.Time, string, string)
        want (context.Context, <-chan time.Time, string, string)

so we tried to solve this issue by adding a latest version of fabric-sdk "go get github.com/hyperledger/fabric-sdk-go@latest" but we could'nt solve this issue. we followed the second solution in - https://stackoverflow.com/questions/55811937/getting-error-not-enough-arguments-in-call-to-s-statsd-sendloop-when-running We changed the vendor source code file of sytem.go by adding a extra params of "context.Background()" in the function SendLoop(context.Background(),s.sendTicker.C, network, address) ,and we build the file it worked, But again we deleted the vendor file and tried running the code we got the same error Please if someone look into this issue make sure we want solution for this issue without change the source code of vendor file we don't want to edit the source code is there any other way to solve this issue?

moledo-gataca commented 2 years ago

Good morning,

You already had the fix. We need a new tag.

https://github.com/hyperledger/fabric-sdk-go/commit/14047c6d88f0e995f09d55817bfbf735e245547a#r66658442

samu-gataca commented 2 years ago

Hello, this issue is a pain. I saw the problem has been fixed, but when you plan to release a new tag? @troyronda It's explained in the comments here: https://github.com/hyperledger/fabric-sdk-go/commit/14047c6d88f0e995f09d55817bfbf735e245547a#r66658442

Regards