search

hyperledger / fabric-sdk-node

Hyperledger Fabric SDK for Node https://wiki.hyperledger.org/display/fabric
https://hyperledger.github.io/fabric-sdk-node/
Apache License 2.0
793 stars 516 forks source link

Register and enroll users removal #672

Closed rajat-dlt closed 1 year ago

rajat-dlt commented 1 year ago

I was planning to give a fix for an issue I found in the fabric-ca-client, the grpc connections were not getting reused. If we're using a higher Node Version.

But the problem is fabric-ca-client states that it is deprecated with Fabric V2.5.

And in the fabirc-gateway, there's no option to register and enroll users. Even the samples use the created certificates. Using the fabric-gateway, how is a user supposed to register and enroll new users ?

This is very confusing for a new person as he won't understand how to register users on the network.

rajat-dlt commented 1 year ago

@bestbeforetoday, maybe I'm missing something. Could you please shed light on this?

bestbeforetoday commented 1 year ago

As I understand it, the direction (since Fabric v2.2 was released) was for the Fabric CLI commands to be the primary tool for performing administrative operations. The overhead of maintaining the (already inconsistent) admin capability implemented in each of the language SDKs, in addition to the CLI commands, made it difficult to continue that approach.

There has been some effort made to provide a specific admin-focused API in the hyperledger/fabric-admin-sdk repository, but the focus has been on a Go implementation (to support Kubernetes/Cloud deployment). This only covers channel creation/configuration and chaincode deployment, not registering and enrolling users with the Fabric CA since - at least in theory - the Fabric CA is an optional rather than core component and can be replaced by an alternative CA.

Having said all that, the fabric-ca-client in the Node SDK is not disappearing and should still continue to work with the Fabric CA. I am happy to accept community contributions to fix issues or even (within reason) add enhancements.

rajat-dlt commented 1 year ago

Thanks for such a detailed response. I'll go ahead and raise a PR for the fix that I think might really help.