search

hyperledger / fabric

Hyperledger Fabric is an enterprise-grade permissioned distributed ledger framework for developing solutions and applications. Its modular and versatile design satisfies a broad range of industry use cases. It offers a unique approach to consensus that enables performance at scale while preserving privacy.
https://wiki.hyperledger.org/display/fabric
Apache License 2.0
15.57k stars 8.79k forks source link

BFT Block Puller: unit test the DeliveryRequester #4567

Open tock-ibm opened 7 months ago

tock-ibm commented 7 months ago

add unit tests for the internal/pkg/peer/blocksprovider/delivery_requester.go against a real GRPC service, with security etc.

solo-daemon commented 3 months ago

@tock-ibm I would like to work on this. Is someone working on this?

solo-daemon commented 3 months ago

Also it seems that the file may have been moved to common/deliverclient/blocksprovider/delivery_requester.go

tock-ibm commented 3 months ago

@solo-daemon Thanks for the contribution! I merged your unit tests PR, but see comments here: https://github.com/hyperledger/fabric/pull/4798#discussion_r1568722794

If you could address these comments in a new PR that would be great.

solo-daemon commented 3 months ago

@tock-ibm sure I would add another pr shortly.

solo-daemon commented 2 months ago

@tock-ibm I have added the suggested changes please take a look