Closed C0rWin closed 1 week ago
--- FAIL: TestBlockPullerBadBlocks (10.17s)
--- FAIL: TestBlockPullerBadBlocks/wrong_number (10.02s)
deliver_test.go:1193: PullBlock did not complete within time
2024-08-27 19:43:17.184 UTC 133f INFO [grpc] Infof -> [transport] [client-transport 0xc00021e248] Closing: connection error: desc = "error reading from server: EOF"
doesn't seem related to my change, re-running UT job again.
Github is still using 22.04 for ubuntu-latest, and is still calling 24.04 'beta' for some reason - https://github.com/actions/runner-images?tab=readme-ov-file#available-images. How do you feel about using 22.04 for a more incremental step up?
Not an issue for fabric, but for fabric-ca since it uses CGO updating to a version later than the ultimate server runs causes issues. For this reason I like to keep fabric-ca a little more behind. But I'd be comfortable with 22.04 across all the repositories.
Github is still using 22.04 for ubuntu-latest, and is still calling 24.04 'beta' for some reason - https://github.com/actions/runner-images?tab=readme-ov-file#available-images. How do you feel about using 22.04 for a more incremental step up?
Not an issue for fabric, but for fabric-ca since it uses CGO updating to a version later than the ultimate server runs causes issues. For this reason I like to keep fabric-ca a little more behind. But I'd be comfortable with 22.04 across all the repositories.
I am just fine to use 22.04 also, just feeling more secure to going with the most recent LTS. But I am ok, let's start with 22.04 and then plan switching to 24.04 later on.
@denyeart, per your suggestion, changed to 22.04.
Thanks @C0rWin , I think we should also update in each of the github workflows under .github/workflows, right?
Thanks @C0rWin , I think we should also update in each of the github workflows under .github/workflows, right?
I've done a separate PR - https://github.com/hyperledger/fabric/pull/4986
Thanks @C0rWin , I think we should also update in each of the github workflows under .github/workflows, right?
yeap
@C0rWin I can also move -latest
to 24.04, let me know
Talked to Ry, we're just going to use fabric-ubuntu-22.04
for the time being.
In the Makefile 22.04
is correct, merged.
Moving container images from using Ubuntu 20.04 to Ubuntu 24.04, this is to reduce amount of vulnerabilities reported with 20.04 version, effectively from this
to this